Skip to content

Add FOSSA checks to Jenkins CI - #144

Merged
tiborvass merged 1 commit into
docker:masterfrom
droopy4096:master
Sep 17, 2019
Merged

Add FOSSA checks to Jenkins CI#144
tiborvass merged 1 commit into
docker:masterfrom
droopy4096:master

Conversation

@droopy4096

@droopy4096droopy4096 commented Sep 11, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@droopy4096droopy4096 changed the title WIP [TAR-1082] add CI Job for Fossa checks[TAR-1082] add CI Job for Fossa checksSep 13, 2019
zelahi
zelahi suggested changes Sep 13, 2019
View reviewed changes

@zelahizelahi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small knitpicks and a change that I should have pointed out earlier. Apologies for not doing so, but we made the fossa-analyzer public now. So we don't have to use the orca creds and pull from the dockereng org. It's mostly so we don't have our secrets in the public repos

Comment threadJenkinsfile Outdated
Comment threadJenkinsfile Outdated
Comment threadMakefile.fossa Outdated
Comment threadJenkinsfile Outdated
Comment threadJenkinsfile Outdated
@tiborvass

tiborvass commented Sep 13, 2019

Copy link
Copy Markdown
Collaborator

Is this makefile a generic makefile you have in other repos? I'm asking because it is not using any Makefile specifics, so it might as well be a simple shell script that could be put in hack.

@droopy4096

droopy4096 commented Sep 16, 2019

Copy link
Copy Markdown
ContributorAuthor

that is correct - that's the boilerplate Makefile we've used in other places. We're working on improvements - this is our first "fast" iteration to get FOSSA coverage across the board.

tiborvass
tiborvass reviewed Sep 17, 2019
View reviewed changes
Comment threadMakefile.fossa Outdated
tiborvass
tiborvass reviewed Sep 17, 2019
View reviewed changes
Comment threadJenkinsfile
tiborvass
tiborvass reviewed Sep 17, 2019
View reviewed changes
Comment threadJenkinsfile Outdated
tiborvass
tiborvass previously approved these changes Sep 17, 2019
View reviewed changes
@tiborvass
tiborvass dismissed their stale reviewSeptember 17, 2019 21:15

too many commits

Dmytro MakoveyTibor Vass
Add FOSSA checks to Jenkins CI
5f4d4a8
Signed-off-by: Dmytro Makovey <dmytro.makovey@docker.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
@tiborvasstiborvass changed the title [TAR-1082] add CI Job for Fossa checksAdd FOSSA checks to Jenkins CISep 17, 2019
@tiborvass
tiborvass merged commit 7c97854 into docker:masterSep 17, 2019
@thaJeztahthaJeztah mentioned this pull request Mar 4, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiborvasstiborvasstiborvass approved these changes
+1 more reviewer
@zelahizelahizelahi requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@droopy4096@tiborvass@zelahi