Skip to content

test: fix non-deterministic compose context path - #2014

Merged
crazy-max merged 1 commit into
docker:masterfrom
crazy-max:fix-compose-test
Aug 23, 2023
Merged

test: fix non-deterministic compose context path#2014
crazy-max merged 1 commit into
docker:masterfrom
crazy-max:fix-compose-test

Conversation

@crazy-max

@crazy-maxcrazy-max commented Aug 23, 2023

Copy link
Copy Markdown
Member

related to #1971

Since #1971 the context path is now absolute and although the tests run fine in our containerized environment, it wouldn't work running the tests locally, such as:

=== CONT TestReadTargetsCompose
bake_test.go:306: Error Trace:	X:/dev/neard/www/github/docker_org/buildx/bake/bake_test.go:306
Error: Not equal: expected: "/src/bake"
actual : "/home/foo/buildx/bake"

glours
glours approved these changes Aug 23, 2023
View reviewed changes

@gloursglours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max
test: fix non-deterministic compose context path
56d55a4
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
crazy-max merged commit 296832c into docker:masterAug 23, 2023
@crazy-max
crazy-max deleted the fix-compose-test branch August 23, 2023 09:27
@crazy-maxcrazy-max mentioned this pull request Jan 24, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gloursgloursglours approved these changes
@tonistiigitonistiigiAwaiting requested review from tonistiigi
@jedevcjedevcAwaiting requested review from jedevc

Assignees

No one assigned

Labels

area/bake/composekind/tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crazy-max@glours