Skip to content

build: set local dirs as frontend attributes - #2156

Merged
tonistiigi merged 1 commit into
docker:masterfrom
crazy-max:frontend-attr-localdirs
Jan 3, 2024
Merged

build: set local dirs as frontend attributes#2156
tonistiigi merged 1 commit into
docker:masterfrom
crazy-max:frontend-attr-localdirs

Conversation

@crazy-max

@crazy-maxcrazy-max commented Dec 13, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Set local dirs metadata if relative to working VCS directory so dockerfile path is tracked accurately.

@crazy-max
crazy-max marked this pull request as ready for review December 14, 2023 09:38
@crazy-max
crazy-maxforce-pushed the frontend-attr-localdirs branch from 144d1b7 to e3466d9CompareDecember 15, 2023 14:33
tonistiigi
tonistiigi reviewed Dec 15, 2023
View reviewed changes

@tonistiigitonistiigi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @cdupuis

Comment threadbuild/git.go Outdated
Comment threadbuild/git.go Outdated
Comment threadbuild/git.go Outdated
Comment threadbuild/build.go Outdated
@crazy-max
crazy-maxforce-pushed the frontend-attr-localdirs branch 3 times, most recently from 8ef55c4 to 0f72361CompareDecember 19, 2023 08:23
@crazy-max
crazy-maxforce-pushed the frontend-attr-localdirs branch from 0f72361 to 7b4f991CompareDecember 19, 2023 14:01
tonistiigi
tonistiigi reviewed Dec 19, 2023
View reviewed changes
Comment threadbuild/git.go Outdated
Comment threadbuild/git.go Outdated
@crazy-max
crazy-maxforce-pushed the frontend-attr-localdirs branch from 7b4f991 to 93ef603CompareDecember 20, 2023 15:16
@crazy-max
build: set local dirs as frontend attributes
02bc4e8
Set local dirs metadata if relative to VCS directory so
dockerfile path is tracked accurately in case vcs information
is not fulfilled.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
crazy-maxforce-pushed the frontend-attr-localdirs branch from 93ef603 to 02bc4e8CompareDecember 21, 2023 10:38
@crazy-maxcrazy-max added this to the v0.13.0 milestone Dec 23, 2023
cdupuis
cdupuis approved these changes Jan 3, 2024
View reviewed changes

@cdupuiscdupuis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for the PR. It solves a big challenge for Scout.

@tonistiigi
tonistiigi merged commit 671347d into docker:masterJan 3, 2024
@crazy-max
crazy-max deleted the frontend-attr-localdirs branch January 3, 2024 08:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigitonistiigitonistiigi approved these changes
+1 more reviewer
@cdupuiscdupuiscdupuis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.13.0

Development

Successfully merging this pull request may close these issues.

3 participants

@crazy-max@cdupuis@tonistiigi