Uh oh!
There was an error while loading. Please reload this page.
docs: use absolute links and update link targets - #2253
Merged
Conversation
dvdksn
commented
Feb 9, 2024
ContributorAuthor
Docs upstream workflow will be broken until main is updated |
crazy-max
approved these changes
Feb 9, 2024
tonistiigi
left a comment
Member
There was a problem hiding this comment.
Is this absolutely needed? It breaks the links when viewing md files in github.
dvdksn
commented
Feb 10, 2024
ContributorAuthor
Alternatively we patch cli-docs-tool to rewrite the links when generating yaml. @thaJeztah had the same concern. But that could be something for a follow-up I think. |
dvdksnforce-pushed
the
docs-cli-reference-urlscheme
branch
2 times, most recently
from
February 12, 2024 08:41
9ae59a4 to
8a25f63ComparethaJeztah
commented
Feb 12, 2024
Member
|
dvdksnforce-pushed
the
docs-cli-reference-urlscheme
branch
from
February 13, 2024 13:29
8a25f63 to
3df6612CompareSigned-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksnforce-pushed
the
docs-cli-reference-urlscheme
branch
2 times, most recently
from
February 20, 2024 07:43
2284a49 to
07ac568CompareSigned-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksnforce-pushed
the
docs-cli-reference-urlscheme
branch
from
February 20, 2024 07:56
07ac568 to
cdfc35dComparecrazy-max
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com