Uh oh!
There was an error while loading. Please reload this page.
bake: check for empty build network with compose - #2790
Merged
Conversation
crazy-maxforce-pushed
the
fix-network-attr-yaml
branch
from
November 14, 2024 18:14
c71d551 to
6e3a566Comparecrazy-maxforce-pushed
the
fix-network-attr-yaml
branch
from
November 14, 2024 18:23
6e3a566 to
0c07256CompareSigned-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-maxforce-pushed
the
fix-network-attr-yaml
branch
from
November 14, 2024 18:28
0c07256 to
4897778Comparecrazy-max
marked this pull request as ready for review
November 14, 2024 20:53
tonistiigi
left a comment
Member
There was a problem hiding this comment.
What case is it fixing? Is the issue that compose parser is reusing some of the pointers it returns?
crazy-max
commented
Nov 14, 2024
MemberAuthor
This is similar to what we got with hcl in #2689 but this time for compose |
tonistiigi
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to docker/docs#21410 (comment)