Uh oh!
There was an error while loading. Please reload this page.
refactor: mutualize builder logic - #865
Closed
crazy-max wants to merge 2 commits into
Closed
Conversation
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
marked this pull request as ready for review
November 27, 2021 12:25
crazy-max
marked this pull request as draft
November 30, 2021 17:29
errordeveloper
left a comment
Contributor
There was a problem hiding this comment.
As we discussed, perhaps it would be good to make a separate PR for the first commit here that could merged soon :)
crazy-max
commented
Dec 7, 2022
MemberAuthor
closing this one, see #1430 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up #830
Has been reviewed based on your comments@tonistiigi. After that we will be able to implement filter/format for some commands. I kept some kubernetes driver logic as it was before but it should be moved to its own factory.