Uh oh!
There was an error while loading. Please reload this page.
remove test-dependencies in favor of stdlib - #22
Conversation
thaJeztah
commented
Mar 9, 2022
To be fair. the "diff" (actual/expected) may be a bit wonky 😅 - let me know if that's a problem |
crazy-max
commented
Mar 9, 2022
Yeah a bit, do you have an issue with transitive deps on another repo? |
thaJeztah
commented
Mar 9, 2022
Not directly, so I'm fine waiting with this. I think I originally looked at what it was used for, and all seemed "trivial enough to not need a dependency for that", but now looking again, the reason I didn't push may have been because of this specific case. I'll give it some thinking (perhaps we can only add go-cmp (e.g.) |
e30202f to
5b32f0aCompare5b32f0a to
0a10850Compare| github.com/cpuguy83/go-md2man/v2 v2.0.7 // indirect | ||
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/inconshreveable/mousetrap v1.1.0 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| github.com/russross/blackfriday/v2 v2.1.0 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect |
There was a problem hiding this comment.
Maybe we should consider this PR after all; at least it gets rid of the deprecated gopkg.in/yaml.v3 (indirect) dependency 🤔
WDYT @crazy-max ?
Uh oh!
There was an error while loading. Please reload this page.
0a10850 to
b4dbe4dCompareSigned-off-by: Sebastiaan van Stijn <github@gone.nl>
Apparently I had this in my local checkout, but never committed or pushed it 😂. Don't know where I left off, but it seems to be complete 🤷♂️