Uh oh!
There was an error while loading. Please reload this page.
add public function to generate docs and remove old files - #43
Conversation
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
fea6905 to
7470ed4CompareCodecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
glours
commented
Nov 2, 2023
@crazy-max@thaJeztah sorry to ping you but I can't add reviewers in this repo |
thaJeztah
commented
Nov 3, 2023
👋 sorry, saw the PR yesterday, but didn't have time to comment. I'm ever-so-slightly wondering what the best approach is for these cases, although not "strongly" attached (this repository is a tool/utility and not a polished end-product, so "whatever works, even if quirky, or opinionated" is probably "fine"). Effectively, it's similar to, e.g., I guess the difference would be that My concern is somewhat (but again: it's a quirky tool, so "whatever works") that we wouldn't be able to tell if the generator "OWNS" a file just by looking at its name; I could have a manually maintained |
thaJeztah
commented
Nov 3, 2023
@crazy-max any good suggestions? (I'm not blocking this PR though if this is the best solution) |
crazy-max
commented
Nov 7, 2023
Would have been better with a variadic opt on |
glours
commented
Nov 7, 2023
@crazy-max I created a new public function to avoid mis-usage of the original |
Since we're using the
alphacommand in Compose, we need to remove sub commands which may either be remove or promote as official commands.See docker/compose#11155 as example