Uh oh!
There was an error while loading. Please reload this page.
Remove Kubernetes commands from experimental - #1068
Merged
vdemeester merged 1 commit intoMay 28, 2018
Merged
Conversation
mat007
approved these changes
May 20, 2018
vdemeester
approved these changes
May 25, 2018
vdemeester
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 🐯
Let's wait for the required PR to get merge before merging this one though 👼
silvin-lubeckiforce-pushed
the
remove-experimental-for-orchestrator
branch
from
May 28, 2018 10:25
271acef to
72fdc36Comparesilvin-lubecki
commented
May 28, 2018
ContributorAuthor
Rebased |
thaJeztah
requested changes
May 28, 2018
| }, | ||
| { | ||
| doc: "kubernetesConfigFile", | ||
| configfile: `{ |
Member
There was a problem hiding this comment.
Looks like there's a couple more "experimental": "enabled" below; think those can be removed as well?
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
silvin-lubeckiforce-pushed
the
remove-experimental-for-orchestrator
branch
from
May 28, 2018 13:06
72fdc36 to
f2b75a8Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
I removed the experimentalCli annotations and all the experimental code linked to the Kubernetes features.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
