Uh oh!
There was an error while loading. Please reload this page.
Warn if DOCKER_ORCHESTRATOR is still used but not DOCKER_STACK_ORCHESTRATOR - #1139
Merged
silvin-lubecki merged 2 commits intoJun 23, 2018
Merged
Conversation
thaJeztahforce-pushed
the
add_orchestrator_warning
branch
from
June 22, 2018 20:57
25c3b3d to
eca068bCompareSigned-off-by: Sebastiaan van Stijn <github@gone.nl>
…TRATOR Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
add_orchestrator_warning
branch
from
June 22, 2018 20:58
eca068b to
e8c87f7Comparevdemeester
approved these changes
Jun 23, 2018
vdemeester
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 🐸
cc @silvin-lubecki
silvin-lubecki
approved these changes
Jun 23, 2018
silvin-lubecki
commented
Jun 23, 2018
Contributor
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1137, and based on that branch; only the last commit is new