Skip to content

[18.06] backport bash completion enhancements - #1173

Merged
albers merged 2 commits into
docker:18.06from
thaJeztah:18.06-backport-bash-completion
Jul 2, 2018
Merged

[18.06] backport bash completion enhancements#1173
albers merged 2 commits into
docker:18.06from
thaJeztah:18.06-backport-bash-completion

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Jul 2, 2018

Copy link
Copy Markdown
Member

Backport of;

/cc @vdemeester@albers

albers added 2 commits July 2, 2018 15:12
@albers@thaJeztah
Add bash completion for dockerd --default-address-pool
547b9a4
Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit 0e6d9df)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@albers@thaJeztah
Add bash completion for exec_die event
74b30e7
Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit 8443982)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztah requested a review from albers as a code ownerJuly 2, 2018 13:13
@thaJeztahthaJeztah added this to the 18.06.0 milestone Jul 2, 2018
silvin-lubecki
silvin-lubecki approved these changes Jul 2, 2018
View reviewed changes

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vdemeester
vdemeester approved these changes Jul 2, 2018
View reviewed changes

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

albers
albers approved these changes Jul 2, 2018
View reviewed changes

@albersalbers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@albers
albers merged commit c6c52ae into docker:18.06Jul 2, 2018
@thaJeztah
thaJeztah deleted the 18.06-backport-bash-completion branch July 2, 2018 18:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albersalbersalbers approved these changes
@silvin-lubeckisilvin-lubeckisilvin-lubecki approved these changes
+1 more reviewer
@vdemeestervdemeestervdemeester approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/completionstatus/2-code-review

Projects

None yet

Milestone

18.06.0

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah@vdemeester@albers@silvin-lubecki@GordonTheTurtle