Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 2.2k
Bump kube dependency to 1.11.0, and update other deps#1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Diff view
Diff view
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using the tag directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Yes, there's been many discussions about those. Ideally, there'd be a way to specify both tag and commit/sha;
reason to use a tag:
reason to not use a tag:
vendor checkfailed and no changes were made in the vendor.conf)v1.0(but we thought it was a tag), then found out about that (again) whenvendor checkfailed.So... how to get the best of both worlds?
It's tricky; because we also have to verify that the commit matches the tag 😞 possibly the
git describenotation would be an option, e.g.;v0.2.0-7-g1817cd4v0.2.01817cd4not sure if that actually verifies if they match though? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, lot's of issues I wasn't aware of 😓 Then that's ok for me 😸