Uh oh!
There was an error while loading. Please reload this page.
Update proxy config if present - #1317
Merged
Merged
Conversation
If the system has a containerd-proxy managing the lifecycle of the daemon, make sure the config is updated with the new image on update. Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
crosbymichael
commented
Aug 28, 2018
Contributor
LGTM |
andrewhsu
commented
Aug 28, 2018
Contributor
@dhiltgen needs port to master branch? |
dhiltgen
commented
Aug 28, 2018
ContributorAuthor
Yes, I'll get a cherry-pick going shortly. |
| return err | ||
| } | ||
| enc := json.NewEncoder(fd) | ||
| return enc.Encode(cfg) |
Contributor
There was a problem hiding this comment.
don't we need to check "enc != nil" before we call enc.Encode?
selansen
commented
Aug 29, 2018
Contributor
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the system has a containerd-proxy managing the lifecycle
of the daemon, make sure the config is updated with the new image
on update.
Example manual test scenario: