Skip to content

Remove stack configs on stack removal - #134

Merged
ehazlett merged 1 commit into
docker:masterfrom
johnstep:remove_stack_configs
May 30, 2017
Merged

Remove stack configs on stack removal#134
ehazlett merged 1 commit into
docker:masterfrom
johnstep:remove_stack_configs

Conversation

@johnstep

Copy link
Copy Markdown
Contributor

Signed-off-by: John Stephens johnstep@docker.com

Signed-off-by: John Stephens <johnstep@docker.com>
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #134 into master will increase coverage by 0.02%.
The diff coverage is 75%.

@@ Coverage Diff @@## master #134 +/- ##
==========================================
+ Coverage 44.82% 44.85% +0.02% 
==========================================
Files 169 169 Lines 11360 11375 +15 ==========================================
+ Hits 5092 5102 +10 - Misses 5978 5981 +3 - Partials 290 292 +2

@dnephindnephin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehazlettehazlett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehazlett
ehazlett merged commit f573976 into docker:masterMay 30, 2017
@johnstep
johnstep deleted the remove_stack_configs branch June 1, 2017 15:28
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
[17.06] Re-vendor swarmkit for various fixes
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@johnstep@codecov-io@ehazlett@dnephin@vdemeester@thaJeztah@GordonTheTurtle