Skip to content

Include stack service configs in service specs - #135

Merged
cpuguy83 merged 1 commit into
docker:masterfrom
johnstep:fix_stack_service_configs
May 30, 2017
Merged

Include stack service configs in service specs#135
cpuguy83 merged 1 commit into
docker:masterfrom
johnstep:fix_stack_service_configs

Conversation

@johnstep

Copy link
Copy Markdown
Contributor

Signed-off-by: John Stephens johnstep@docker.com

@johnstepjohnstep added this to the 17.06.0 milestone May 27, 2017
@johnstep
johnstep requested a review from cpuguy83May 27, 2017 04:12
@johnstepjohnstep mentioned this pull request May 27, 2017
23 tasks
Signed-off-by: John Stephens <johnstep@docker.com>
@johnstep
johnstepforce-pushed the fix_stack_service_configs branch from 8b8c64e to b7cac96CompareMay 27, 2017 04:41
@codecov-io

codecov-io commented May 27, 2017

Copy link
Copy Markdown

Codecov Report

Merging #135 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #135 +/- ##
==========================================
- Coverage 44.82% 44.82% -0.01% 
==========================================
Files 169 169 Lines 11360 11361 +1 ==========================================
Hits 5092 5092 - Misses 5978 5979 +1 
Partials 290 290

@johnstepjohnstep changed the title Include stack service configs in the service specInclude stack service configs in service specsMay 27, 2017
@vdemeester
vdemeester requested a review from dnephinMay 29, 2017 02:25

@dnephindnephin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83

Copy link
Copy Markdown
Collaborator

Do we have a unit test for convertService?

@dnephin

Copy link
Copy Markdown
Contributor

There isn't currently, but it should be possible to write one

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

@cpuguy83cpuguy83 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
cpuguy83 merged commit ebd5191 into docker:masterMay 30, 2017
@johnstep
johnstep deleted the fix_stack_service_configs branch June 1, 2017 15:28
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@johnstep@codecov-io@cpuguy83@dnephin@vdemeester@thaJeztah@GordonTheTurtle