Uh oh!
There was an error while loading. Please reload this page.
[master] Expose licensing details before loading - #1400
Merged
Conversation
Help the user understand which license they're about to load in case they have multiple licenses they need to figure out. Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com> (cherry picked from commit 5a97a93) Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com> (cherry picked from commit 41910b6) Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
Signed-off-by: Andrew Hsu <andrewhsu@docker.com> (cherry picked from commit a7488d1) Signed-off-by: Daniel Hiltgen <daniel.hiltgen@docker.com>
codecov-io
commented
Sep 28, 2018
Codecov Report
@@ Coverage Diff @@## master #1400 +/- ##
==========================================
- Coverage 54.31% 54.29% -0.02%
==========================================
Files 289 289 Lines 19318 19326 +8 ==========================================
+ Hits 10492 10494 +2 - Misses 8148 8154 +6
Partials 678 678 |
ContributorAuthor
Once this goes in I'll forward port #1388 to master as well. |
seemethere
approved these changes
Sep 29, 2018
crosbymichael
commented
Oct 1, 2018
Contributor
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forward port #1387 to master