Skip to content

Remove deprecated -e/--email flag from docker login - #143

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:remove-email-flag
Jun 2, 2017
Merged

Remove deprecated -e/--email flag from docker login#143
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:remove-email-flag

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Jun 1, 2017

Copy link
Copy Markdown
Member

The docker login -e / docker login --email option was deprecated in
Docker 1.11 (https://github.com/moby/moby/releases/tag/v1.11.0) through
aee260d (April 2016), and when used has
been outputing a deprecation warning since;

Flag --email has been deprecated, will be removed in 17.06.

Originally this option was scheduled to be removed in docker 1.13, but
extended to docker 17.06 due to a change in our deprecation policy.

Given that only docker 1.10 and older use this flag (which is EOL, including
for CS versions, as of February 2017), will now be removed.

With this patch, docker login will now produce an Error if the flag
is used.

closesmoby/moby#23390

The `docker login -e` / `docker login --email` option was deprecated in
Docker 1.11 (https://github.com/moby/moby/releases/tag/v1.11.0) through
aee260d (April 2016), and when used has
been outputing a deprecation warning since;
Flag --email has been deprecated, will be removed in 17.06.
Originally this option was scheduled to be removed in docker 1.13, but
extended to docker 17.06 due to a change in our deprecation policy.
Given that only docker 1.10 and older use this flag (which is EOL, including
for CS versions, as of February 2017), will now be removed.
With this patch, `docker login` will now produce an Error if the flag
is used.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #143 +/- ##
=======================================
Coverage 44.96% 44.96% =======================================
Files 169 169 Lines 11378 11378 =======================================
Hits 5116 5116 Misses 5970 5970 Partials 292 292

@dnephindnephin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

All :green:

@thaJeztah
thaJeztah merged commit a0066a1 into docker:masterJun 2, 2017
@thaJeztahthaJeztah mentioned this pull request Jun 7, 2017
40 tasks
@thaJeztah
thaJeztah deleted the remove-email-flag branch June 9, 2017 09:58
mooyoul added a commit to balmbees/opsworks_custom_cookbooks that referenced this pull request Jun 29, 2017
matiasgarciaisaia added a commit to instedd/active-monitoring that referenced this pull request Dec 13, 2017
matiasgarciaisaia added a commit to instedd/cruzroja-registro that referenced this pull request Jun 28, 2018
It has been removed a while ago
See docker/cli#143
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
[17.07] Fix error handling with not-exist errors on remove
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore docker login -e option flag

5 participants

@thaJeztah@codecov-io@vdemeester@dnephin@GordonTheTurtle