Uh oh!
There was an error while loading. Please reload this page.
Allow --detach and --quiet flags when using --rollback - #144
Conversation
Commit 78c204e added (f9bd8ec in the moby repo) a validation to prevent `--rollback` from being used in combination with other flags that update the service spec. This validation was not taking into account that some flags only affect the CLI behavior, and are okay to be used when rolling back. This patch updates the validation, and adds `--quiet` and `--detach` to the list of allowed flags. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
aaronlehmann
commented
Jun 1, 2017
LGTM |
Codecov Report
@@ Coverage Diff @@## master #144 +/- ##
=======================================
Coverage 44.96% 44.96% =======================================
Files 169 169 Lines 11378 11378 =======================================
Hits 5116 5116 Misses 5970 5970 Partials 292 292 |
cpuguy83
commented
Jun 1, 2017
Kind of stinks we can't specify the rollback order when rolling back. |
aaronlehmann
commented
Jun 1, 2017
@cpuguy83: For the swarm manager to know it's doing a rollback, the rollback has to happen server-side instead of the client just submitting |
thaJeztah
commented
Jun 1, 2017
Also related to this; #142
Perhaps a |
[17.06] cluster: Avoid recursive RLock
Commit 78c204e (moby/moby@f9bd8ec / moby/moby#31108 in the moby repo) added a validation to prevent
--rollbackfrom being used in combination with other flags that update the service spec.This validation was not taking into account that some flags only affect the CLI behavior, and are okay to be used when rolling back.
This patch updates the validation, and adds
--quietand--detachto the list of allowed flags.relates to moby/moby#33444 (comment)