Skip to content

display message improve in run - #1448

Closed
lifubang wants to merge 1 commit into
docker:masterfrom
acmcodercom:runerrmsgdisplay
Closed

display message improve in run#1448
lifubang wants to merge 1 commit into
docker:masterfrom
acmcodercom:runerrmsgdisplay

Conversation

@lifubang

Copy link
Copy Markdown
Contributor

Signed-off-by: Lifubang lifubang@acmcoder.com

- What I did

root@dockerdemo:~/gocode/src/github.com/docker/cli# build/docker --debug -H tcp://localhost:113 run -itd --name=test12 -p 32770:6379 redis
build/docker: Cannot connect to the Docker daemon at tcp://localhost:113. Is the docker daemon running?.
See 'build/docker run --help'.
root@dockerdemo:~/gocode/src/github.com/docker/cli#

There is "." after "?"
I think it looks ugly.

- How I did it
When [\n\r\!\.\?]$.MatchString(str), no need add "."

Signed-off-by: Lifubang <lifubang@acmcoder.com>
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1448 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #1448 +/- ##
=========================================
+ Coverage 54.2% 54.2% +<.01% 
=========================================
Files 289 289 Lines 19378 19380 +2 =========================================
+ Hits 10503 10505 +2 
Misses 8199 8199 Partials 676 676

@thaJeztah

Copy link
Copy Markdown
Member

Closing, as this code was removed in #5236

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lifubang@codecov-io@thaJeztah@GordonTheTurtle