Skip to content

[18.09 backport] fixes #1441 set default schema to tcp for docker host - #1454

Merged
andrewhsu merged 2 commits into
docker:18.09from
thaJeztah:18.09_backport_defaulttcpschema
Nov 27, 2018
Merged

[18.09 backport] fixes #1441 set default schema to tcp for docker host#1454
andrewhsu merged 2 commits into
docker:18.09from
thaJeztah:18.09_backport_defaulttcpschema

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Oct 17, 2018•
edited
Loading

Copy link
Copy Markdown
Member

backport of #1443 for 18.09
fixes#1441
fixesmoby/moby#38118

git checkout -b 18.09_backport_defaulttcpschema upstream/18.09 git cherry-pick -s -S -x 2431dd144809812e8d3bb03d22af01703a5d36cd
git cherry-pick -s -S -x beed8748c0b7072db3cc1d8a2680a8b4856922a6
git push -u origin

cherry-pick was clean; no conflicts

@lifubang@thaJeztah
set default schema to tcp for docker host
aeea559
Signed-off-by: Lifubang <lifubang@acmcoder.com>
(cherry picked from commit 2431dd1)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@lifubang@thaJeztah
add test case TestNewAPIClientFromFlagsForDefaultSchema
8ae4453
Signed-off-by: Lifubang <lifubang@acmcoder.com>
(cherry picked from commit beed874)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah added this to the 18.09.0 milestone Oct 17, 2018
@thaJeztahthaJeztah mentioned this pull request Oct 17, 2018
Merged
cpuguy83
cpuguy83 approved these changes Oct 17, 2018
View reviewed changes

@cpuguy83cpuguy83 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io

codecov-io commented Oct 17, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1454 into 18.09 will decrease coverage by <.01%.
The diff coverage is 66.66%.

@@ Coverage Diff @@## 18.09 #1454 +/- ##
==========================================
- Coverage 54.07% 54.06% -0.01% 
==========================================
Files 290 290 Lines 19391 19390 -1 ==========================================
- Hits 10485 10484 -1 
Misses 8237 8237 Partials 669 669

silvin-lubecki
silvin-lubecki approved these changes Oct 17, 2018
View reviewed changes

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lifubang
lifubang approved these changes Oct 18, 2018
View reviewed changes

@lifubanglifubang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztahthaJeztah mentioned this pull request Oct 31, 2018
Closed
@thaJeztahthaJeztah modified the milestones: 18.09.0, 18.09.1Nov 8, 2018
@zmilonas

zmilonas commented Nov 20, 2018

Copy link
Copy Markdown

Is there a reason this wasn't merged?

andrewhsu
andrewhsu approved these changes Nov 27, 2018
View reviewed changes

@andrewhsuandrewhsu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu
andrewhsu merged commit 3f79899 into docker:18.09Nov 27, 2018
@thaJeztah
thaJeztah deleted the 18.09_backport_defaulttcpschema branch November 27, 2018 18:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83cpuguy83cpuguy83 approved these changes
@silvin-lubeckisilvin-lubeckisilvin-lubecki approved these changes
+2 more reviewers
@andrewhsuandrewhsuandrewhsu approved these changes
@lifubanglifubanglifubang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

18.09.1

Development

Successfully merging this pull request may close these issues.

8 participants

@thaJeztah@codecov-io@zmilonas@andrewhsu@lifubang@cpuguy83@silvin-lubecki@GordonTheTurtle