Uh oh!
There was an error while loading. Please reload this page.
docs(metrics-addr): Use port 9323, allocated for Docker in prometheus - #1589
Conversation
GordonTheTurtle
commented
Dec 21, 2018
Please sign your commits following these rules: $ git clone -b "patch-1" git@github.com:fhemberger/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
codecov-io
commented
Dec 21, 2018
Codecov Report
@@ Coverage Diff @@## master #1589 +/- ##
=======================================
Coverage 55.25% 55.25% =======================================
Files 289 289 Lines 19395 19395 =======================================
Hits 10716 10716 Misses 7983 7983 Partials 696 696 |
1 similar comment
codecov-io
commented
Dec 21, 2018
Codecov Report
@@ Coverage Diff @@## master #1589 +/- ##
=======================================
Coverage 55.25% 55.25% =======================================
Files 289 289 Lines 19395 19395 =======================================
Hits 10716 10716 Misses 7983 7983 Partials 696 696 |
silvin-lubecki
left a comment
There was a problem hiding this comment.
LGTM, thank you @fhemberger !
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! Overall looks good, but I left some suggestions.
Could you address those comments (and amend your commit, so that all changes are in a single commit)?
Based on the branch name (patch-1) I suspect you opened this PR through GitHub's web-interface, and amending a commit requires you to make those changes from the command line, so it's a bit more work to make those changes 😅
Let me know if you want to make those changes yourself, or if you want me to carry those (happy to make them for you)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
fhemberger
commented
Dec 21, 2018
@thaJeztah Thanks for your feedback, updated the PR. PTAL. |
Signed-off-by: Frederic Hemberger <mail@frederic-hemberger.de>
thaJeztah
left a comment
There was a problem hiding this comment.
perfect, LGTM!
thank you so much!
fhemberger
commented
Dec 22, 2018
You're welcome! |
According to https://github.com/prometheus/prometheus/wiki/Default-port-allocations,
9323is the default port associated with Docker metrics. It should be used in the example as well to avoid assigning a random port which may interfere with other prometheus exporters on the same machine.