Skip to content

Improve docker image rm reference docs - #1629

Merged
silvin-lubecki merged 1 commit into
docker:masterfrom
thaJeztah:update_rmi_docs
Mar 18, 2019
Merged

Improve docker image rm reference docs#1629
silvin-lubecki merged 1 commit into
docker:masterfrom
thaJeztah:update_rmi_docs

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

Copies the improved description from the man page (made in #1444) to the online reference docs.

/cc @SvenDowideit 👍

Copies the improved description from the man page
to the online reference docs.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1629 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1629 +/- ##
=======================================
Coverage 55.16% 55.16% =======================================
Files 301 301 Lines 20384 20384 =======================================
Hits 11244 11244 Misses 8335 8335 Partials 805 805

@SvenDowideit

Copy link
Copy Markdown
Contributor

yup, LGTM

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

ping @vdemeester@silvin-lubecki PTAL 🙏

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Comment threaddocs/reference/commandline/rmi.md
@veeara282

Copy link
Copy Markdown

@thaJeztah Thanks for creating this pull request! I was trying to submit an issue about this myself.

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki
silvin-lubecki merged commit 33c8c05 into docker:masterMar 18, 2019
@GordonTheTurtleGordonTheTurtle added this to the 19.03.0 milestone Mar 18, 2019
@thaJeztah
thaJeztah deleted the update_rmi_docs branch March 18, 2019 09:51
@veeara282

Copy link
Copy Markdown

This change shows up at docker rmi but not docker image rm.

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

That's being discussed; likely redirects will be made to redirect the pages to their canonical command

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@thaJeztah@codecov-io@SvenDowideit@veeara282@vdemeester@silvin-lubecki@GordonTheTurtle