Skip to content

Fix small typo - #1646

Merged
thaJeztah merged 1 commit into
docker:masterfrom
ryanwilsonperkin:patch-1
Feb 8, 2019
Merged

Fix small typo#1646
thaJeztah merged 1 commit into
docker:masterfrom
ryanwilsonperkin:patch-1

Conversation

@ryanwilsonperkin

Copy link
Copy Markdown
Contributor

- What I did
Noticed a typo in this markdown file: "instead" instead of "in stead"

- How I did it
Github integrated editor 💪

- How to verify it
😉 https://english.stackexchange.com/questions/227644/instead-of-vs-in-stead-of

- Description for the changelog

Typo fix in the docker stats documentation.

- A picture of a cute animal (not mandatory but encouraged)
img_20180929_153044

@GordonTheTurtle

Copy link
Copy Markdown

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:ryanwilsonperkin/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@ryanwilsonperkin

Copy link
Copy Markdown
ContributorAuthor

@GordonTheTurtle hi! It seems your account is tied to the dco/no check. I contributed this PR via the Github integrated editor, and so the commit is automatically "verified" by GitHub along with a generated GPG key. Is this now allowed via this dco rule?

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1646 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1646 +/- ##
======================================
Coverage 56.1% 56.1% ======================================
Files 300 300 Lines 20601 20601 ======================================
Hits 11559 11559 Misses 8209 8209 Partials 833 833

@silvin-lubecki

Copy link
Copy Markdown
Contributor

Hello @ryanwilsonperkin , thank you for fixing this typo. @GordonTheTurtle is our signed-off bot which checks that every commit has a signed-off section at the end with your real full name.

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>

Can you amend your commit with it?

Noticed a typo in this markdown file: "instead" instead of "in stead"
Signed-off-by: Ryan Wilson-Perkin <ryanwilsonperkin@gmail.com>

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah
thaJeztah merged commit 5f2ef6a into docker:masterFeb 8, 2019
@GordonTheTurtleGordonTheTurtle added this to the 19.03.0 milestone Feb 8, 2019
@ryanwilsonperkin
ryanwilsonperkin deleted the patch-1 branch February 8, 2019 23:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ryanwilsonperkin@GordonTheTurtle@codecov-io@silvin-lubecki@thaJeztah