Skip to content

Note caveat with detaching using key sequence - #1665

Merged
thaJeztah merged 1 commit into
docker:masterfrom
jcrben:patch-1
Feb 26, 2019
Merged

Note caveat with detaching using key sequence#1665
thaJeztah merged 1 commit into
docker:masterfrom
jcrben:patch-1

Conversation

@jcrben

@jcrbenjcrben commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

@GordonTheTurtle

Copy link
Copy Markdown

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:jcrben/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@jcrben

Copy link
Copy Markdown
ContributorAuthor

My commit is Github "Verified"; kinda surprised that isn't enough. I'll see about pulling it down.

I tested using -t and -i independently (with an image I had on hand, redis) and it didn't work - needed both and then it emitted read escape sequence and closed.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1665 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1665 +/- ##
=======================================
Coverage 56.07% 56.07% =======================================
Files 306 306 Lines 20950 20950 =======================================
Hits 11747 11747 Misses 8354 8354 Partials 849 849

This has come up a few times, e.g. moby/moby#20864 and moby/moby#35491
Signed-off-by: Ben Creasy <ben@bencreasy.com>
@thaJeztah

Copy link
Copy Markdown
Member

My commit is Github "Verified"; kinda surprised that isn't enough. I'll see about pulling it down.

Yes, sorry about that; it's checking for a "DCO" sign-off (which is different than the commit being GPG-signed).

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ping @vdemeester ptal

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thaJeztah
thaJeztah merged commit 2178fea into docker:masterFeb 26, 2019
@GordonTheTurtleGordonTheTurtle added this to the 19.03.0 milestone Feb 26, 2019
@jcrben
jcrben deleted the patch-1 branch February 26, 2019 18:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jcrben@GordonTheTurtle@codecov-io@thaJeztah@silvin-lubecki