Uh oh!
There was an error while loading. Please reload this page.
Note caveat with detaching using key sequence - #1665
Conversation
GordonTheTurtle
commented
Feb 8, 2019
Please sign your commits following these rules: $ git clone -b "patch-1" git@github.com:jcrben/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
jcrben
commented
Feb 8, 2019
My commit is Github "Verified"; kinda surprised that isn't enough. I'll see about pulling it down. I tested using |
codecov-io
commented
Feb 8, 2019
Codecov Report
@@ Coverage Diff @@## master #1665 +/- ##
=======================================
Coverage 56.07% 56.07% =======================================
Files 306 306 Lines 20950 20950 =======================================
Hits 11747 11747 Misses 8354 8354 Partials 849 849 |
This has come up a few times, e.g. moby/moby#20864 and moby/moby#35491 Signed-off-by: Ben Creasy <ben@bencreasy.com>
thaJeztah
commented
Feb 26, 2019
Yes, sorry about that; it's checking for a "DCO" sign-off (which is different than the commit being GPG-signed). |
This has come up a few times, for example:
- What I did
N/A
- How I did it
N/A
- How to verify it
N/A
- Description for the changelog
Update documentation of
docker attachto note caveat with detaching using key sequence.- A picture of a cute animal (not mandatory but encouraged)

(from https://commons.wikimedia.org/wiki/File:Beagle_puppy_Cadet_2.jpg)