Corrected max-file option - was incorrectly spelt as max-files

[stevejr]

Signed-off-by: stevejr <>

- What I did

- How I did it

- How to verify it
Used the option spelt as max-files and confirmed the docker daemon would not restart. Amended to max-file and it started

- Description for the changelog

Corrected the spelling of the max-file sub-option for log-opts - was spelt as max-files but should be max-file as per https://docs.docker.com/config/containers/logging/json-file/

- A picture of a cute animal (not mandatory but encouraged)

[GordonTheTurtle]

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "correct-dockerd-max-file-opt" git@github.com:stevejr/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

[codecov-io]

Codecov Report

Merging #1670 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1670 +/- ##
=======================================
Coverage 56.12% 56.12% =======================================
Files 306 306 Lines 20964 20964 =======================================
Hits 11766 11766 Misses 8345 8345 Partials 853 853

[thaJeztah]

Nice catch, thanks!

Confirmed that this is the correct name for this option;

mkdir -p /etc/docker
echo'{"log-opts": {"max-files":"5"}}'> /etc/docker/daemon.json
dockerd
...
Error starting daemon: failed to set log opts: unknown log opt 'max-files'for json-file log driver
echo'{"log-opts": {"max-file":"5"}}'> /etc/docker/daemon.json
...
INFO[2019-02-13T12:04:36.215638800Z] Daemon has completed initialization INFO[2019-02-13T12:04:36.226260100Z] API listen on /var/run/docker.sock 

[thaJeztah]

changes look good to me, but looks like there's an issue with the DCO sign off;

Signed-off-by: stevejr <>

Can you change this to your real name (Steve Richards), and set your e-mail address between the brackets (<your e-mail address>? Otherwise CI won't pass 😅

[stevejr]

@thaJeztah - Signed off text changed

[thaJeztah]

LGTM, thanks!