Uh oh!
There was an error while loading. Please reload this page.
Add exit status to docker exec manpage - #1674
Conversation
GordonTheTurtle
commented
Feb 15, 2019
Please sign your commits following these rules: $ git clone -b "patch-1" git@github.com:ericcurtin/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Codecov Report
@@ Coverage Diff @@## master #1674 +/- ##
==========================================
+ Coverage 56.12% 56.12% +<.01%
==========================================
Files 306 306 Lines 21025 20964 -61 ==========================================
- Hits 11800 11766 -34 + Misses 8371 8345 -26 + Partials 854 853 -1 |
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
looks consistent with https://github.com/docker/cli/blob/561f6e399c3a0863c7b78ab797553b878cc4e73a/docs/reference/run.md#exit-status
Thanks!
thaJeztah
commented
Feb 21, 2019
ping @vdemeester@silvin-lubecki ptal |
| $ docker exec --foo busybox; echo $? | ||
| # flag provided but not defined: --foo | ||
| See 'docker exec --help'. | ||
| 125 |
There was a problem hiding this comment.
Isn't this example of an error within the Docker CLI, rather than the daemon, it's the CLI which isn't recognising the --foo here isn't it?
There was a problem hiding this comment.
Good question; will have to dig into the history of that. Perhaps this was done on purpose to being able to distinguish a exit 1 (from the container's process) from an exit 1 (from the docker cli (or daemon))?
There was a problem hiding this comment.
I can add a different example if you guys have a common one off the top of your heads! I'm away for the weekend now, can try and recreate a 125 when I get back.
There was a problem hiding this comment.
not sure if another example is possible (as in; I think the 125 is generated in the CLI, as it won't send the flag to the daemon if it's invalid 🤔
There was a problem hiding this comment.
@thaJeztah IOW it is the description not the example which is wrong both here and in https://github.com/docker/cli/blob/561f6e399c3a0863c7b78ab797553b878cc4e73a/docs/reference/run.md#exit-status?
There was a problem hiding this comment.
Will I remove it for the moment?
There's little way of knowing what each exit status means at present because it's not documented. I'm assuming they are the same as docker run. Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
ericcurtin
commented
Feb 25, 2019
Removed 125 exit status from man page |
ericcurtin
commented
Mar 7, 2019
Poke poke @ijc@thaJeztah@vdemeester@silvin-lubecki I removed 125. Is this good to go? |
ijc
left a comment
There was a problem hiding this comment.
LGTM (not a maintainer)
I think we should probably be accurately describing what 125 means rather than omitting it, but this is adding correct and useful information so is a worthwhile improvement and not worth blocking over "perfection".
ericcurtin
commented
Mar 13, 2019
@thaJeztah@vdemeester@silvin-lubecki any of you guys want to grab? |
There's little way of knowing what each exit status means at present
because it's not documented. I'm assuming they are the same as
docker run.