Skip to content

Bash completion: add '--replicas-max-per-node' - #1686

Merged
tiborvass merged 1 commit into
docker:masterfrom
thaJeztah:max_replicas_completion
Feb 22, 2019
Merged

Bash completion: add '--replicas-max-per-node'#1686
tiborvass merged 1 commit into
docker:masterfrom
thaJeztah:max_replicas_completion

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

whoops; realised we didn't add this one (follow up to #1612)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

@olljanat@albers@vdemeester ptal 🤗

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1686 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1686 +/- ##
=======================================
Coverage 56.07% 56.07% =======================================
Files 306 306 Lines 20997 20997 =======================================
Hits 11774 11774 Misses 8373 8373 Partials 850 850

@olljanat

olljanat commented Feb 22, 2019

Copy link
Copy Markdown
Contributor

Looks good 👍

@albersalbers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiborvass
tiborvass merged commit 3ddb313 into docker:masterFeb 22, 2019
@GordonTheTurtleGordonTheTurtle added this to the 19.03.0 milestone Feb 22, 2019
@thaJeztah
thaJeztah deleted the max_replicas_completion branch February 22, 2019 22:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@thaJeztah@codecov-io@olljanat@tiborvass@albers@GordonTheTurtle