Uh oh!
There was an error while loading. Please reload this page.
Reformat the output of CLI plugins in docker system info - #1689
Merged
silvin-lubecki merged 1 commit intoFeb 26, 2019
Conversation
codecov-io
commented
Feb 25, 2019
Codecov Report
@@ Coverage Diff @@## master #1689 +/- ##
==========================================
+ Coverage 56.12% 56.12% +<.01%
==========================================
Files 306 306 Lines 21025 21028 +3 ==========================================
+ Hits 11800 11803 +3
Misses 8371 8371 Partials 854 854 |
This matches the `docker --help` output after 9201360. Added a unit test case for unversioned. Signed-off-by: Ian Campbell <ijc@docker.com>
ijcforce-pushed
the
plugins-docker-system-info-format
branch
from
February 25, 2019 13:14
2291cbf to
3c28326ComparethaJeztah
approved these changes
Feb 26, 2019
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM
with this change;
Client:
Debug Mode: false
Plugins:
compose: Define and run multi-container applications (Docker, Inc.)
helloworld: A basic Hello World plugin for tests (Docker Inc., testing)
Server:
Containers: 14
Running: 8
Paused: 0
Stopped: 6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the
docker --helpoutput after 9201360.Signed-off-by: Ian Campbell ijc@docker.com
This covers one of the outstanding items in #1661.