Uh oh!
There was an error while loading. Please reload this page.
Disable docker system dial-stdio on Windows - #1710
Conversation
The `conn` here is `*winio.win32MessageBytePipe` which does not have a `CloseRead` method (it does have `CloseWrite`) resulting in: docker@WIN-NUC0 C:\Users\docker>.\docker-windows-amd64.exe system dial-stdio the raw stream connection does not implement halfCloser Also disable the path which uses this for cli-plugins on Windows. Signed-off-by: Ian Campbell <ijc@docker.com>
AkihiroSuda
commented
Mar 5, 2019
According to #1376 it works on Windows with certain configuration? |
AkihiroSuda
commented
Mar 5, 2019
I think |
ijc
commented
Mar 5, 2019
Ah, I guess there it is a proper tcp socket (which I would guess does indeed support half close in both directions since it is tcp) since it is doing For me (using dial-stdio in a plugin to connect back to the local dameon) it is (I presume) the named pipe, which I suppose doesn't. |
ddebroy
commented
Mar 6, 2019
/cc @andrey-ko for taking a look at the Windows side of this. |
ijc
commented
Mar 6, 2019
@thaJeztah I think this is only tangentially related to plugins (cf the label) |
ijc
commented
Mar 6, 2019
#1718 is my attempt to fix this on Windows, PTAL (my testing on Windows has been rather limited) |
- Update docker/cli is now pointing to ulyssessouza/cli. The change needs the merge of docker/cli#1710 and docker/cli#1690 - Fix issues relative paths in Jenkinsfile and Jenkinsfile.baguette - Avoid using '--config' in favor of env variable 'DOCKER_CONFIG' Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
- Update docker/cli is now pointing to ulyssessouza/cli. The change needs the merge of docker/cli#1710 and docker/cli#1690 - Fix issues relative paths in Jenkinsfile and Jenkinsfile.baguette - Avoid using '--config' in favor of env variable 'DOCKER_CONFIG' Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
silvin-lubecki
commented
Mar 11, 2019
Merged, to be reverted when #1718 will land. |
The
connhere is*winio.win32MessageBytePipewhich does not have aCloseReadmethod (it does haveCloseWrite) resulting in:Also disable the path which uses this for cli-plugins on Windows.
Signed-off-by: Ian Campbell ijc@docker.com
/cc @tonistiigi@AkihiroSuda if Windows can't be fixes soon perhaps we should do this and revert when Windows works?