Skip to content

Update golang 1.8.3#173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiborvass merged 1 commit into from
Jun 9, 2017
Merged

Update golang 1.8.3 #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.cross
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@

FROM golang:1.8.1
FROM golang:1.8.3

@andrewhsuandrewhsuJun 9, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the Dockerfile.dev floats the golang version to latest patch of 1.8. I'd suggest floating the version in Dockerfile.cross as well so they match, .e.g. FROM golang:1.8

@thaJeztahthaJeztahJun 9, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure; we've had cases where a patch release brought a specific fix, using a rolling update would make it undeterministic

@andrewhsuandrewhsuJun 9, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'd suggest making sure all Dockerfiles are locked into a specific golang version. The 3 files in dockerfiles dir.

@thaJeztahthaJeztahJun 9, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be my personal preference

@StefanSchererStefanSchererJun 9, 2017

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the other two Dockerfiles as well to use golang 1.8.3


# allow replacing httpredir or deb mirror
ARG APT_MIRROR=deb.debian.org
Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.dev
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@

FROM golang:1.8-alpine
FROM golang:1.8.3-alpine

RUN apk add -U git make bash coreutils

Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.lint
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
FROM golang:1.8-alpine
FROM golang:1.8.3-alpine

RUN apk add -U git

Expand Down