Uh oh!
There was an error while loading. Please reload this page.
[18.09 backport] dial-stdio: handle connections which lack CloseRead method - #1733
Merged
tiborvass merged 2 commits intoMar 21, 2019
Merged
Conversation
added 2 commits
March 13, 2019 11:53
This happens on Windows when dialing a named pipe (a path which is used by CLI plugins), in that case some debugging shows: DEBU[0000] conn is a *winio.win32MessageBytePipe DEBU[0000] conn is a halfReadCloser: false DEBU[0000] conn is a halfWriteCloser: true the raw stream connection does not implement halfCloser In such cases we can simply wrap with a nop function since closing for read isn't too critical. Signed-off-by: Ian Campbell <ijc@docker.com> (cherry picked from commit 8919bbf) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This was leaking the fd. Signed-off-by: Ian Campbell <ijc@docker.com> (cherry picked from commit 186e745) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Mar 13, 2019
MemberAuthor
ping @ijc@silvin-lubecki@AkihiroSuda@cpuguy83 PTAL |
codecov-io
commented
Mar 13, 2019
Codecov Report
@@ Coverage Diff @@## 18.09 #1733 +/- ##
==========================================
- Coverage 54.09% 54.07% -0.03%
==========================================
Files 290 290 Lines 19406 19414 +8 ==========================================
Hits 10498 10498 - Misses 8236 8244 +8
Partials 672 672 |
1 similar comment
codecov-io
commented
Mar 13, 2019
Codecov Report
@@ Coverage Diff @@## 18.09 #1733 +/- ##
==========================================
- Coverage 54.09% 54.07% -0.03%
==========================================
Files 290 290 Lines 19406 19414 +8 ==========================================
Hits 10498 10498 - Misses 8236 8244 +8
Partials 672 672 |
tiborvass
approved these changes
Mar 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #1718 for 18.09 (omitting the "revert" commit (0449ad8), which is not needed for this branch)