Uh oh!
There was an error while loading. Please reload this page.
[18.09 backport] Fix: plugin-tests discarding current environment - #1741
Merged
silvin-lubecki merged 1 commit intoMar 18, 2019
Merged
Conversation
By default, exec uses the environment of the current process, however, if `exec.Env` is not `nil`, the environment is discarded: https://github.com/golang/go/blob/e73f4894949c4ced611881329ff8f37805152585/src/os/exec/exec.go#L57-L60 > If Env is nil, the new process uses the current process's environment. When adding a new environment variable, prepend the current environment, to make sure it is not discarded. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 6c4fbb7) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Mar 17, 2019
MemberAuthor
codecov-io
commented
Mar 17, 2019
Codecov Report
@@ Coverage Diff @@## 18.09 #1741 +/- ##
=======================================
Coverage 54.09% 54.09% =======================================
Files 290 290 Lines 19406 19406 =======================================
Hits 10498 10498 Misses 8236 8236 Partials 672 672 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #1713 for 18.09
By default, exec uses the environment of the current process, however,
if
exec.Envis notnil, the environment is discarded:https://github.com/golang/go/blob/e73f4894949c4ced611881329ff8f37805152585/src/os/exec/exec.go#L57-L60
When adding a new environment variable, prepend the current environment,
to make sure it is not discarded.
Signed-off-by: Sebastiaan van Stijn github@gone.nl
(cherry picked from commit 6c4fbb7)
Signed-off-by: Sebastiaan van Stijn github@gone.nl
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)