Skip to content

Add some spaces in docs for cosmetics and readability reasons. - #1748

Merged
thaJeztah merged 1 commit into
docker:masterfrom
silvin-lubecki:cosmetics
Mar 18, 2019
Merged

Add some spaces in docs for cosmetics and readability reasons.#1748
thaJeztah merged 1 commit into
docker:masterfrom
silvin-lubecki:cosmetics

Conversation

@silvin-lubecki

Copy link
Copy Markdown
Contributor

image

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah

Copy link
Copy Markdown
Member

Hm... keep running into these timing out; not sure what changed; perhaps it was always just on the edge of 10 minutes, and now slightly over?

Successfully tagged cli-builder-with-git:23114
time make -B vendor
make[1]: Entering directory '/go/src/github.com/docker/cli'
rm -rf vendor
bash -c 'vndr |& grep -v -i clone'
2019/03/18 11:38:26 Collecting initial packages
Too long with no output (exceeded 10m0s)

@thaJeztah

Copy link
Copy Markdown
Member

Opened #1750 to reduce flakiness

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1748 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1748 +/- ##
======================================
Coverage 56.1% 56.1% ======================================
Files 306 306 Lines 21049 21049 ======================================
Hits 11810 11810 Misses 8382 8382 Partials 857 857

@thaJeztah
thaJeztah merged commit 8091814 into docker:masterMar 18, 2019
@GordonTheTurtleGordonTheTurtle added this to the 19.03.0 milestone Mar 18, 2019
@silvin-lubecki
silvin-lubecki deleted the cosmetics branch March 18, 2019 12:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@silvin-lubecki@thaJeztah@codecov-io@GordonTheTurtle