Skip to content

Update compose 3.8 to disallow additional properties - #1749

Merged
vdemeester merged 1 commit into
docker:masterfrom
thaJeztah:compose_3.8_compose_credential_spec_fix
Mar 18, 2019
Merged

Update compose 3.8 to disallow additional properties#1749
vdemeester merged 1 commit into
docker:masterfrom
thaJeztah:compose_3.8_compose_credential_spec_fix

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Mar 18, 2019

Copy link
Copy Markdown
Member

This was added in other schemas in 1e99ed3 (#1657), but not copied to schema 3.8

ping @vdemeester@silvin-lubecki PTAL

This was added in other schemas in 1e99ed3,
but not coppied to version 3.8
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1749 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1749 +/- ##
======================================
Coverage 56.1% 56.1% ======================================
Files 306 306 Lines 21049 21049 ======================================
Hits 11810 11810 Misses 8382 8382 Partials 857 857

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦁

@vdemeester
vdemeester merged commit f2123b3 into docker:masterMar 18, 2019
@GordonTheTurtleGordonTheTurtle added this to the 19.03.0 milestone Mar 18, 2019
@thaJeztah
thaJeztah deleted the compose_3.8_compose_credential_spec_fix branch March 18, 2019 18:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah@codecov-io@vdemeester@silvin-lubecki@GordonTheTurtle