Skip to content

[18.09 backport] CircleCI: Increase no-output timeout to 15 minutes for vendoring - #1793

Merged
kolyshkin merged 1 commit into
docker:18.09from
thaJeztah:18.09_backport_fix_circle_vendor_flakiness
Jul 23, 2019
Merged

[18.09 backport] CircleCI: Increase no-output timeout to 15 minutes for vendoring#1793
kolyshkin merged 1 commit into
docker:18.09from
thaJeztah:18.09_backport_fix_circle_vendor_flakiness

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

backport of #1750

Vendoring can take some time, depending on network-speed, so
reduce flakiness by increasing the default timeout, to prevent:

make[1]: Entering directory '/go/src/github.com/docker/cli'
rm -rf vendor
bash -c 'vndr |& grep -v -i clone'
2019/03/18 11:38:26 Collecting initial packages
Too long with no output (exceeded 10m0s)

Vendoring can take some time, depending on network-speed, so
reduce flakiness by increasing the default timeout, to prevent:
make[1]: Entering directory '/go/src/github.com/docker/cli'
rm -rf vendor
bash -c 'vndr |& grep -v -i clone'
2019/03/18 11:38:26 Collecting initial packages
Too long with no output (exceeded 10m0s)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit dba90e4)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1793 into 18.09 will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## 18.09 #1793 +/- ##
=======================================
Coverage 54.22% 54.22% =======================================
Files 290 290 Lines 19428 19428 =======================================
Hits 10535 10535 Misses 8214 8214 Partials 679 679

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztahthaJeztah modified the milestones: 18.09.6, 18.09.7Jun 14, 2019
@andrewhsuandrewhsu modified the milestones: 18.09.7, 18.09.8Jun 27, 2019
@thaJeztahthaJeztah modified the milestones: 18.09.8, 18.09.9Jul 18, 2019

@kolyshkinkolyshkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin
kolyshkin merged commit 7969d87 into docker:18.09Jul 23, 2019
@thaJeztah
thaJeztah deleted the 18.09_backport_fix_circle_vendor_flakiness branch July 24, 2019 01:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@thaJeztah@codecov-io@kolyshkin@silvin-lubecki@andrewhsu@GordonTheTurtle