Skip to content

Bump Golang 1.12.3#1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdemeester merged 1 commit into from
Apr 12, 2019
Merged

Bump Golang 1.12.3 #1818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions appveyor.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,7 +4,7 @@ clone_folder: c:\gopath\src\github.com\docker\cli

environment:
GOPATH: c:\gopath
GOVERSION: 1.12.2
GOVERSION: 1.12.3
DEPVERSION: v0.4.1

install:
Expand All@@ -20,4 +20,4 @@ build_script:
- ps: .\scripts\make.ps1 -Binary

test_script:
- ps: .\scripts\make.ps1 -TestUnit
- ps: .\scripts\make.ps1 -TestUnit

@tao12345666333tao12345666333Apr 11, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is because of no newline at end of file.

2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.binary-native
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
FROM golang:1.12.2-alpine
FROM golang:1.12.3-alpine

RUN apk add -U git bash coreutils gcc musl-dev

Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.cross
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
FROM dockercore/golang-cross:1.12.2@sha256:ea93d7ed5b464e5163cf8df40a198ad54afe6a59e1ca335c9bc4a5ed3702f2d0
FROM dockercore/golang-cross:1.12.3@sha256:b88a6be2469d321601f87675c49d1b3f166c4c37abc5ce3e74557fc6660481be

@tao12345666333tao12345666333Apr 11, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @thaJeztahsaid,

I'm actually thinking of removing this "pin by digest", as it doesn't add much for our use-case 🤔

I also agree very much. Do we need to remove this "pin by digest" ? 🤔

@thaJeztahthaJeztahApr 11, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with removing it

@vdemeester@silvin-lubecki SGTY?

ENV DISABLE_WARN_OUTSIDE_CONTAINER=1
WORKDIR /go/src/github.com/docker/cli
COPY . .
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.dev
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
FROM golang:1.12.2-alpine
FROM golang:1.12.3-alpine

RUN apk add -U git make bash coreutils ca-certificates curl

Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.e2e
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
ARG GO_VERSION=1.12.2
ARG GO_VERSION=1.12.3

FROM docker/containerd-shim-process:a4d1531 AS containerd-shim-process

Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/Dockerfile.lint
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
FROM golang:1.12.2-alpine
FROM golang:1.12.3-alpine

RUN apk add -U git

Expand Down