Uh oh!
There was an error while loading. Please reload this page.
Do not call the config endpoint if API is lower than 1.30 - #182
Conversation
| } | ||
| if versions.LessThan(version.APIVersion, "1.30") { | ||
| return []swarm.Config{}, nil | ||
| } |
There was a problem hiding this comment.
I wonder if we should still print a warning (otherwise people may not be aware an option was ignored)
3ab7849 to
fd7a10aCompareCodecov Report
@@ Coverage Diff @@## master #182 +/- ##
==========================================
- Coverage 45.67% 45.31% -0.37%
==========================================
Files 171 171 Lines 11505 11487 -18 ==========================================
- Hits 5255 5205 -50 - Misses 5946 5982 +36 + Partials 304 300 -4 |
fd7a10a to
1c76877ComparethaJeztah
commented
Jun 12, 2017
Perhaps make the warning more consistent with the error messages we have (and mention which API version is needed?) https://github.com/moby/moby/pull/33571/files#diff-c91a3260cd755746371aa100f9b599a6R24 Reading on my phone, haven checked if the docker-compose / stack deploy messages are different 😊 |
1c76877 to
99d2bdbCompare| return err | ||
| } | ||
| if versions.LessThan(version.APIVersion, "1.30") { | ||
| fmt.Fprintf(dockerCli.Err(), "WARNING: requires API version 1.30, but the Docker daemon API version is %s", version.APIVersion) |
There was a problem hiding this comment.
What requires API version 1.30? If i saw this message from docker stack rm I would be confused. I think we need to include that this is about "configs" only.
There was a problem hiding this comment.
Oh, I was discussing options with @vdemeester this morning; guess I should've put them here, as he didn't come to updating yet 👍
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
99d2bdb to
2128b3fComparevdemeester
commented
Jun 14, 2017
@dnephin@thaJeztah updated 👼 |
thaJeztah
commented
Jun 14, 2017
oh! forgot to actually LGTM.. well, LGTM! thanks 😂 |
…-19.03-578ab52ece34b084621954e0b543003410cdbe84 [19.03] sync to upstream 19.03 578ab52
[17.07] Add make vendor target
Another would be to handle
Page not founderror in those cases 👼(and moby/moby#33571 could help too 👼)
Fix#180
/cc @mavenugo@friism
Signed-off-by: Vincent Demeester vincent@sbr.pm