Skip to content

Reformat vendor.conf and pin all deps by git-sha - #1822

Merged
vdemeester merged 2 commits into
docker:masterfrom
thaJeztah:format_vendor
Apr 12, 2019
Merged

Reformat vendor.conf and pin all deps by git-sha#1822
vdemeester merged 2 commits into
docker:masterfrom
thaJeztah:format_vendor

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

to make it better readable, and to encourage pinning by sha, but "align" to a tagged release.

Also sorted the list again

To make it better readable, and to encourage pinning
by sha, but "align" to a tagged release.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

ping @vdemeester@silvin-lubecki PTAL

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1822 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1822 +/- ##
=======================================
Coverage 56.31% 56.31% =======================================
Files 308 308 Lines 21429 21429 =======================================
Hits 12068 12068 Misses 8476 8476 Partials 885 885

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree with this PR !

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@vdemeester
vdemeester merged commit a125283 into docker:masterApr 12, 2019
@GordonTheTurtleGordonTheTurtle added this to the 19.03.0 milestone Apr 12, 2019
@thaJeztah
thaJeztah deleted the format_vendor branch April 12, 2019 07:36
thaJeztah added a commit to thaJeztah/cli that referenced this pull request Jun 20, 2019
To make it better readable, and to encourage pinning
by sha, but "align" to a tagged release.
similar to 6026ce4 (docker#1822)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah added a commit to thaJeztah/cli that referenced this pull request Jul 23, 2019
To make it better readable, and to encourage pinning
by sha, but "align" to a tagged release.
similar to 6026ce4 (docker#1822)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah@codecov-io@vdemeester@silvin-lubecki@GordonTheTurtle