Skip to content

Bump Golang 1.12.4 - #1832

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:bump_golang_1.12.4
Apr 17, 2019
Merged

Bump Golang 1.12.4#1832
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:bump_golang_1.12.4

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

go1.12.4 (released 2019/04/11) fixes an issue where using the prebuilt
binary releases on older versions of GNU/Linux led to failures when linking
programs that used cgo. Only Linux users who hit this issue need to update.

See golang/go#31293 for details

Full diff: golang/go@go1.12.3...go1.12.4

go1.12.4 (released 2019/04/11) fixes an issue where using the prebuilt
binary releases on older versions of GNU/Linux led to failures when linking
programs that used cgo. Only Linux users who hit this issue need to update.
See golang/go#31293 for details
Full diff: golang/go@go1.12.3...go1.12.4
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1832 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1832 +/- ##
=======================================
Coverage 56.73% 56.73% =======================================
Files 308 308 Lines 21610 21610 =======================================
Hits 12261 12261 Misses 8449 8449 Partials 900 900

@@ -1,4 +1,4 @@
FROM dockercore/golang-cross:1.12.3@sha256:b88a6be2469d321601f87675c49d1b3f166c4c37abc5ce3e74557fc6660481be
FROM dockercore/golang-cross:1.12.4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as I thought. 👍

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I thought; let's do it 😅

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83

Copy link
Copy Markdown
Collaborator

Note that the image is still missing arm variants.

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

upstream tracking issue docker-library/golang#274

@andrewhsu

Copy link
Copy Markdown
Contributor

Looks like arm variants are now up:

$ docker manifest inspect golang:1.12.4 | jq '.manifests[].platform | select(.architecture=="arm64")'
{
"architecture": "arm64",
"os": "linux",
"variant": "v8"
}

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

👍 let's merge

@thaJeztah
thaJeztah merged commit 552e8d1 into docker:masterApr 17, 2019
@GordonTheTurtleGordonTheTurtle added this to the 19.03.0 milestone Apr 17, 2019
@thaJeztah
thaJeztah deleted the bump_golang_1.12.4 branch April 17, 2019 23:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@thaJeztah@codecov-io@cpuguy83@andrewhsu@tao12345666333@silvin-lubecki@GordonTheTurtle