Uh oh!
There was an error while loading. Please reload this page.
Apiversion negotiation - #1845
Merged
Merged
Conversation
tiborvassforce-pushed
the
apiversion-negotiation
branch
from
April 23, 2019 22:23
e914ea4 to
16bc5bfCompareCodecov Report
@@ Coverage Diff @@## master #1845 +/- ##
=======================================
Coverage 56.75% 56.75% =======================================
Files 309 309 Lines 21680 21680 =======================================
Hits 12305 12305 Misses 8476 8476 Partials 899 899 |
thaJeztah
approved these changes
Apr 24, 2019
| @@ -127,6 +127,8 @@ func (c *Endpoint) ClientOpts() ([]client.Opt, error) { | |||
| version := os.Getenv("DOCKER_API_VERSION") | |||
| if version != "" { | |||
| result = append(result, client.WithVersion(version)) | |||
Member
There was a problem hiding this comment.
WithVersion should now ignore empty values, so just adding both WithVersion and WithAPIVersionNegotiation should also work
andrewhsu
commented
Apr 24, 2019
Contributor
SGTM |
thaJeztah
commented
Apr 24, 2019
Member
ping @silvin-lubecki |
thaJeztah
commented
Apr 24, 2019
Member
oh; needs a rebase 😔 |
…on is missing Signed-off-by: Tibor Vass <tibor@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
apiversion-negotiation
branch
from
May 14, 2019 00:37
16bc5bf to
c52e1f2ComparethaJeztah
commented
May 14, 2019
Member
rebased; removed the first commit, because master was up-to-date with those changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to moby/moby#39032
Ping @thaJeztah@tonistiigi@vdemeester@AkihiroSuda