Skip to content

[19.03 backport] backport BuildKit fixes - #1879

Merged
thaJeztah merged 3 commits into
docker:19.03from
thaJeztah:19.03_backport_buildkit_fixes
May 13, 2019
Merged

[19.03 backport] backport BuildKit fixes#1879
thaJeztah merged 3 commits into
docker:19.03from
thaJeztah:19.03_backport_buildkit_fixes

Conversation

@thaJeztah

@thaJeztahthaJeztah commented May 13, 2019

Copy link
Copy Markdown
Member

Tibor Vass added 3 commits May 13, 2019 09:13
Tibor Vass@thaJeztah
build: honor BUILDKIT_PROGRESS env config
529b1e7
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit 8adcedd)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Tibor Vass@thaJeztah
build: add --platform local
8758cdc
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit daca70d)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Tibor Vass@thaJeztah
vendor buildkit to 646fc0af6d283397b9e47cd0a18779e9d0376e0e (v0.5.1)
3f9063e
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit 7f45a0e)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah added this to the 19.03.0 milestone May 13, 2019
@thaJeztah

thaJeztah commented May 13, 2019

Copy link
Copy Markdown
MemberAuthor

ping @tiborvass@tonistiigi PTAL

silvin-lubecki
silvin-lubecki approved these changes May 13, 2019
View reviewed changes

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io

codecov-io commented May 13, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1879 into 19.03 will decrease coverage by 0.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## 19.03 #1879 +/- ##
==========================================
- Coverage 56.75% 56.74% -0.02% 
==========================================
Files 309 309 Lines 21658 21662 +4 ==========================================
Hits 12292 12292 - Misses 8469 8473 +4 
Partials 897 897

@thaJeztah
thaJeztah merged commit 12a1cf4 into docker:19.03May 13, 2019
@thaJeztah
thaJeztah deleted the 19.03_backport_buildkit_fixes branch May 14, 2019 01:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigitonistiigitonistiigi approved these changes
@silvin-lubeckisilvin-lubeckisilvin-lubecki approved these changes

Assignees

No one assigned

Labels

area/builderstatus/2-code-review

Projects

None yet

Milestone

19.03.0

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah@codecov-io@tonistiigi@silvin-lubecki@GordonTheTurtle