Skip to content

e2e: use stable-dind image for testing - #1992

Merged
tiborvass merged 1 commit into
docker:masterfrom
thaJeztah:e2e_stable_dind
Jul 10, 2019
Merged

e2e: use stable-dind image for testing#1992
tiborvass merged 1 commit into
docker:masterfrom
thaJeztah:e2e_stable_dind

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

The edge channel is deprecated and no longer updated

@thaJeztahthaJeztah changed the title e2e: use stable channel for dind daemone2e: use 18.09 daemonJul 10, 2019
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1992 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1992 +/- ##
==========================================
- Coverage 56.74% 56.74% -0.01% 
==========================================
Files 310 310 Lines 21802 21801 -1 ==========================================
- Hits 12371 12370 -1 
Misses 8517 8517 Partials 914 914

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

@silvin-lubecki@vdemeester PTAL; wasn't sure what we preferred here;

  • use test-dind (latest "RC"); gives the advantage of testing against latest/greatest, but this image may change at points so possibly cause inconsistent results
  • use stable-dind same "problem" as above
  • pin to a specific version (this PR); downside is that we don't catch regressions, but positive side is that we know what we're testing against

@vdemeester

Copy link
Copy Markdown
Collaborator

@silvin-lubecki@vdemeester PTAL; wasn't sure what we preferred here;

* use `test-dind` (latest "RC"); gives the advantage of testing against latest/greatest, but this image may change at points so possibly cause inconsistent results
* use `stable-dind` same "problem" as above
* pin to a specific version (this PR); downside is that we don't catch regressions, but positive side is that we know what we're testing against

I think safest bet is stable-dind. We could have another job test-dind that is not a blocker (aka we would see it needs fixing but it wouldn't be required to be green to be able to merge). @thaJeztah wdyt ?

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

I'm good with stable-dind (less maintenance) let me update

The edge channel is deprecated and no longer updated
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah changed the title e2e: use 18.09 daemone2e: use stable-dind image for testingJul 10, 2019
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

updated 👍

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah@codecov-io@vdemeester@tiborvass@GordonTheTurtle