Skip to content

e2e: remove docker engine testing remnants - #1993

Merged
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:e2e_remove_dead_code
Aug 15, 2019
Merged

e2e: remove docker engine testing remnants#1993
thaJeztah merged 1 commit into
docker:masterfrom
thaJeztah:e2e_remove_dead_code

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

These changes were made as part of the docker engine feature in commit fd2f1b3 (#1260), but later reverted in f250152(#1381) and b7ec4a4 (#1385)

These lines were forgotten to be removed, and should no longer be needed.

@thaJeztah
thaJeztahforce-pushed the e2e_remove_dead_code branch from ffe84e6 to d7ae89aCompareJuly 10, 2019 19:27
@codecov-io

codecov-io commented Jul 10, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1993 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #1993 +/- ##
=======================================
Coverage 56.78% 56.78% =======================================
Files 311 311 Lines 21832 21832 =======================================
Hits 12398 12398 Misses 8519 8519 Partials 915 915

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

rebased to trigger CI

These changes were made as part of the `docker engine` feature
in commit fd2f1b3, but later
reverted in f250152 and
b7ec4a4
These lines were forgotten to be removed, and should no longer
be needed.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the e2e_remove_dead_code branch from d7ae89a to de01e72CompareJuly 12, 2019 14:21
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

all green; bringing this one in

@thaJeztah
thaJeztah merged commit aa097cf into docker:masterAug 15, 2019
@GordonTheTurtleGordonTheTurtle added this to the 19.09.0 milestone Aug 15, 2019
@thaJeztah
thaJeztah deleted the e2e_remove_dead_code branch August 15, 2019 01:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah@codecov-io@tiborvass@GordonTheTurtle