Skip to content

[19.03 backport] Bump golang 1.12.7 - #1998

Merged
andrewhsu merged 2 commits into
docker:19.03from
thaJeztah:19.03_backport_bump_golang_1.12.7
Aug 8, 2019
Merged

[19.03 backport] Bump golang 1.12.7#1998
andrewhsu merged 2 commits into
docker:19.03from
thaJeztah:19.03_backport_bump_golang_1.12.7

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

based on top of #1946 (in case we need to do 1.12.6 first)

backport of #1996

go1.12.7 (released 2019/07/08) includes fixes to cgo, the compiler, and the
linker. See the Go 1.12.7 milestone on our issue tracker for details:
https://github.com/golang/go/issues?q=milestone%3AGo1.12.7

full diff: golang/go@go1.12.6...go1.12.7

tao12345666333and others added 2 commits June 13, 2019 15:52
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
(cherry picked from commit 459099e)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
go1.12.7 (released 2019/07/08) includes fixes to cgo, the compiler, and the
linker. See the Go 1.12.7 milestone on our issue tracker for details:
https://github.com/golang/go/issues?q=milestone%3AGo1.12.7
full diff: golang/go@go1.12.6...go1.12.7
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit b06f9e9)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1998 into 19.03 will decrease coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## 19.03 #1998 +/- ##
=========================================
- Coverage 56.71% 56.7% -0.01% 
=========================================
Files 310 310 Lines 21789 21786 -3 =========================================
- Hits 12357 12354 -3 
Misses 8519 8519 Partials 913 913

1 similar comment
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1998 into 19.03 will decrease coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## 19.03 #1998 +/- ##
=========================================
- Coverage 56.71% 56.7% -0.01% 
=========================================
Files 310 310 Lines 21789 21786 -3 =========================================
- Hits 12357 12354 -3 
Misses 8519 8519 Partials 913 913

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

We also might want to have #2013

@thaJeztahthaJeztah changed the title [WIP][19.03 backport] Bump golang 1.12.7[19.03 backport] Bump golang 1.12.7Jul 23, 2019
@thaJeztahthaJeztah modified the milestones: 19.03.1, 19.03.2Jul 26, 2019

@kolyshkinkolyshkin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsuandrewhsu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu
andrewhsu merged commit 1a8077b into docker:19.03Aug 8, 2019
@thaJeztah
thaJeztah deleted the 19.03_backport_bump_golang_1.12.7 branch August 8, 2019 00:48
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@thaJeztah@codecov-io@codecov-commenter@andrewhsu@kolyshkin@GordonTheTurtle@tao12345666333