Skip to content

CircleCI/Jenkins: use buildkit - #2009

Merged
thaJeztah merged 4 commits into
docker:masterfrom
thaJeztah:ci_buildkit
Aug 12, 2019
Merged

CircleCI/Jenkins: use buildkit#2009
thaJeztah merged 4 commits into
docker:masterfrom
thaJeztah:ci_buildkit

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Jul 18, 2019

Copy link
Copy Markdown
Member

follow-up to #1599 rebased

@codecov-io

codecov-io commented Jul 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #2009 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2009 +/- ##
=======================================
Coverage 56.79% 56.79% =======================================
Files 311 311 Lines 21836 21836 =======================================
Hits 12402 12402 Misses 8519 8519 Partials 915 915

@thaJeztah
thaJeztahforce-pushed the ci_buildkit branch 3 times, most recently from f364b59 to 0919b9bCompareJuly 18, 2019 11:38
Comment thread.dockerignore
@@ -1,2 +1,6 @@
.dockerignore

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's super meta 😸

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 yes

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually add the Dockerfile itself as well, didn't take time to look into which Dockerfile may be used docker-in-docker

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztahthaJeztah changed the title CircleCI: use buildkitCircleCI/Jenkins: use buildkitJul 18, 2019
Comment threadJenkinsfile Outdated
@tiborvass

Copy link
Copy Markdown
Collaborator

TestSigProxyWithTTY timed out twice in a row.

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

TestSigProxyWithTTY timed out twice in a row.

Yes. It's flaky for some reason, but I'm unable to reproduce it locally 😞 almost seems machine-specific (help welcome!)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

TestSigProxyWithTTY was fixed in #2016. Rebased this one, and all is green now; merging

@thaJeztah
thaJeztah merged commit f807b5e into docker:masterAug 12, 2019
@GordonTheTurtleGordonTheTurtle added this to the 19.09.0 milestone Aug 12, 2019
@thaJeztah
thaJeztah deleted the ci_buildkit branch August 12, 2019 09:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah@codecov-io@tiborvass@silvin-lubecki@GordonTheTurtle