Skip to content

vendor/github.com/docker/docker/pkg/system: Fix the following compila… - #2033

Closed
wanghuaiqing2010 wants to merge 1 commit into
docker:masterfrom
wanghuaiqing2010:master
Closed

vendor/github.com/docker/docker/pkg/system: Fix the following compila…#2033
wanghuaiqing2010 wants to merge 1 commit into
docker:masterfrom
wanghuaiqing2010:master

Conversation

@wanghuaiqing2010

Copy link
Copy Markdown

…tion problem.

[root@localhost cli]# make dynbinary

WARNING: you are not in a container.
Use "make -f docker.Makefile dynbinary" or set
DISABLE_WARN_OUTSIDE_CONTAINER=1 to disable this warning.

Press Ctrl+C now to abort.

./scripts/build/dynbinary
Building dynamically linked build/docker-linux-mips64le
/tmp/src/github.com/docker/cli/vendor/github.com/docker/docker/pkg/system/stat_linux.go:11:3: cannot use s.Rdev (type uint32) as type uint64 in field value
Makefile:63: recipe for target 'dynbinary' failed
make: *** [dynbinary] Error 2

Signed-off-by: wanghuaiqing wanghuaiqing@loongson.cn

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #2033 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2033 +/- ##
=======================================
Coverage 56.79% 56.79% =======================================
Files 311 311 Lines 21836 21836 =======================================
Hits 12402 12402 Misses 8519 8519 Partials 915 915

Signed-off-by: wanghuaiqing <wanghuaiqing@loongson.cn>
@wanghuaiqing2010

Copy link
Copy Markdown
Author

Hi, I want to fix the following problem.

Building dynamically linked build/docker-linux-mips64le
/tmp/src/github.com/docker/cli/vendor/github.com/docker/docker/pkg/system/stat_linux.go:11:3: cannot use s.Rdev (type uint32) as type uint64 in field value
Makefile:63: recipe for target 'dynbinary' failed
make: *** [dynbinary] Error 2

And I know the problem has been fixed in the following repo.
https://github.com/docker/engine.git

I want to know How to modify the following file under the directory vendor.
cli/vendor/github.com/docker/docker/pkg/system/stat_linux.go

Please help me.

@thaJeztah

Copy link
Copy Markdown
Member

Thanks for contributing; looks like this change was included in another PR, so this one is no longer needed 😊

gid: s.Gid,
rdev: s.Rdev,
// the type is 32bit on mips
rdev: uint64(s.Rdev), // nolint: unconvert

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change was included in 38c02a9 (#2110)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@wanghuaiqing2010@codecov-io@thaJeztah@GordonTheTurtle