Skip to content

Add docker-compose schema v3.9 - #2073

Merged
vdemeester merged 1 commit into
docker:masterfrom
thaJeztah:add_compose_schema_3.9
Sep 3, 2019
Merged

Add docker-compose schema v3.9#2073
vdemeester merged 1 commit into
docker:masterfrom
thaJeztah:add_compose_schema_3.9

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

This is currently just a copy of the v3.8 schema, in preparation of new features to be added in the new schema.

- Description for the changelog

* Add support for docker-compose schema v3.9

- A picture of a cute animal (not mandatory but encouraged)

This is currently just a copy of the v3.8 schema, in preparation
of new features to be added in the new schema.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
MemberAuthor

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #2073 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2073 +/- ##
=======================================
Coverage 56.78% 56.78% =======================================
Files 311 311 Lines 21836 21836 =======================================
Hits 12400 12400 Misses 8520 8520 Partials 916 916

1 similar comment
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #2073 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2073 +/- ##
=======================================
Coverage 56.78% 56.78% =======================================
Files 311 311 Lines 21836 21836 =======================================
Hits 12400 12400 Misses 8520 8520 Partials 916 916

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

oh; @silvin-lubecki is on PTO; @vdemeester LGTY? 🤗

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeestervdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester
vdemeester merged commit 4a57770 into docker:masterSep 3, 2019
@GordonTheTurtleGordonTheTurtle added this to the 19.09.0 milestone Sep 3, 2019
@thaJeztah
thaJeztah deleted the add_compose_schema_3.9 branch September 3, 2019 07:11
@ulgens

Copy link
Copy Markdown

This is currently just a copy of the v3.8 schema, in preparation of new features to be added in the new schema.

Why? I know it's been years but it still looks weird to add fake support for a schema version which doesn't exist. Can someone provide a link to docs for 3.9?

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

Why? I know it's been years but it still looks weird to add fake support for a schema version which doesn't exist.

It's slightly confusing, but this repository was used as a the canonical definition for the 3.x compose schema (which was designed for use with docker stack). The docker compose repository maintained a copy of the definition, and was used to provide documentation for the schemas it supported.

Unfortunately, the compose spec was created using the copy of the schema in the docker/compose repository as starting point (which was slightly behind this repository), which is why some options were not included in the initial implementation of the compose spec (e.g. compose-spec/compose-spec#214)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@thaJeztah@codecov-io@ulgens@vdemeester@silvin-lubecki@GordonTheTurtle