Skip to content

[18.09 backport] bump miekg/pkcs11 v1.0.2 - #2080

Merged
andrewhsu merged 1 commit into
docker:18.09from
thaJeztah:18.09_backport_bump_pkcs11
Oct 23, 2019
Merged

[18.09 backport] bump miekg/pkcs11 v1.0.2#2080
andrewhsu merged 1 commit into
docker:18.09from
thaJeztah:18.09_backport_bump_pkcs11

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

backport of #2051

full diff: miekg/pkcs11@6120d95...v1.0.2

relevant changes:

@silvin-lubeckisilvin-lubecki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki

Copy link
Copy Markdown
Contributor

@thaJeztah: validate complains:

scripts/validate/check-git-diff vendor
These files were changed:
D vendor/github.com/miekg/pkcs11/go.mod

@thaJeztah

Copy link
Copy Markdown
MemberAuthor

Ah, guess we need to backport the vndr bump. Might already be in another PR 🤔

@thaJeztahthaJeztah modified the milestones: 18.09.10, 18.09.11Oct 10, 2019
full diff: miekg/pkcs11@6120d95...v1.0.2
relevant changes:
- miekg/pkcs11#110 Fix issue freeing memory on GetOperationState when NOT CK_OK
- miekg/pkcs11#106 Move to go modules
- miekg/pkcs11#104 Expose login API for vendor specific login types
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 54428b1)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
thaJeztahforce-pushed the 18.09_backport_bump_pkcs11 branch from d50da0a to 400686eCompareOctober 10, 2019 11:06
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #2080 into 18.09 will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## 18.09 #2080 +/- ##
=======================================
Coverage 54.28% 54.28% =======================================
Files 291 291 Lines 19459 19459 =======================================
Hits 10563 10563 Misses 8215 8215 Partials 681 681

@andrewhsuandrewhsu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@andrewhsu
andrewhsu merged commit 6219337 into docker:18.09Oct 23, 2019
@thaJeztah
thaJeztah deleted the 18.09_backport_bump_pkcs11 branch October 23, 2019 16:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@thaJeztah@silvin-lubecki@codecov-io@andrewhsu@GordonTheTurtle