Skip to content

Add device cgroup rules - #2206

Open
agners wants to merge 2 commits into
docker:masterfrom
agners:add-device-cgroup-rules
Open

Add device cgroup rules#2206
agners wants to merge 2 commits into
docker:masterfrom
agners:add-device-cgroup-rules

Conversation

@agners

@agnersagners commented Nov 27, 2019

Copy link
Copy Markdown

This (re-)adds device_cgroup_rules to the compose schema. Currently it is not supported by the docker stack deploy command. This implements what has been suggested in docker/compose#6974

@agners
agnersforce-pushed the add-device-cgroup-rules branch 2 times, most recently from 05d017f to 315e4b2CompareNovember 27, 2019 14:53
@agners

agners commented Dec 5, 2019

Copy link
Copy Markdown
Author

Any comment on this pull request? Maybe also @ndeloof as you commented on the linked docker compose pull request.

@agners

agners commented Dec 19, 2019

Copy link
Copy Markdown
Author

Any comment on this? It is important for us as it enables us to use the 3.x series of Docker Compose schema again...

@agners

agners commented Jan 24, 2020

Copy link
Copy Markdown
Author

@thaJeztah friendly ping? This would be valuable for us!

@agners

agners commented Mar 11, 2020

Copy link
Copy Markdown
Author

@rgulewich I see that you made recently a change to that file, do you happen to know how to get this reviewed/merged?

@rgulewich

rgulewich commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

@agners - Unfortunately, I don't know any trick, other than persistently pinging people every month or so. Maybe try pulling in one of the folks that reviewed my change in #1988 ?

@agners
agnersforce-pushed the add-device-cgroup-rules branch from 315e4b2 to 752f3d8CompareApril 21, 2020 11:57
@agners

agners commented Apr 21, 2020

Copy link
Copy Markdown
Author

Rebased this pull request.

Also created an issue (compose-spec/compose-spec#62) and pull request (compose-spec/compose-spec#63) to add this field in the new compose-spec project.

@thaJeztah I think there is no real opposition to adding this, can you help getting this merged?

@agnersagners mentioned this pull request May 14, 2020
Merged
Stefan Agner added 2 commits June 19, 2020 10:24
Stefan Agner
Readd support for device_cgroup_rules in compose files
2f3628a
This readds support for `device_cgroup_rules` which was present in
compose file format 2.4.
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
Stefan Agner
Add device_cgroup_rules to list of unsupported fields
468657a
Currently `docker stack deploy` does not support this field hence
add it to the list of unsupported fields.
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
@agners
agnersforce-pushed the add-device-cgroup-rules branch from 752f3d8 to 468657aCompareJune 19, 2020 08:26
@agners

agners commented Jun 19, 2020

Copy link
Copy Markdown
Author

@thaJeztah Since this is now in compose-spec already, any chance to get this merged for Docker 20.03 still?

@codecov-commenter

codecov-commenter commented Jun 19, 2020

Copy link
Copy Markdown

Codecov Report

Merging #2206 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #2206 +/- ##
=======================================
Coverage 58.05% 58.05% =======================================
Files 295 295 Lines 21165 21165 =======================================
Hits 12288 12288 Misses 7975 7975 Partials 902 902

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@hc0503hc0503hc0503 approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/stackstatus/0-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@agners@rgulewich@codecov-commenter@hc0503@thaJeztah@GordonTheTurtle@thompson-shaun