Uh oh!
There was an error while loading. Please reload this page.
Remove "docker engine" subcommands - #2207
Merged
Merged
Conversation
This was referenced Dec 5, 2019
Merged
thaJeztahforce-pushed
the
remove_engine_activate
branch
from
December 6, 2019 09:47
894c139 to
7ab820cComparethaJeztah
marked this pull request as ready for review
December 12, 2019 13:40
thaJeztah
commented
Dec 12, 2019
MemberAuthor
ping @andrewhsu@cpuguy83 @docker/core-cli-maintainers |
cpuguy83
commented
Dec 12, 2019
Collaborator
Needs rebase. |
thaJeztahforce-pushed
the
remove_engine_activate
branch
from
December 12, 2019 16:42
7ab820c to
7beab7aCompareThese subcommands were created to allow upgrading a Docker Community engine to Docker Enterprise, but never really took off. This patch removes the `docker engine` subcommands, as they added quite some complexity / additional code. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztahforce-pushed
the
remove_engine_activate
branch
from
December 12, 2019 16:51
7beab7a to
7e54513ComparethaJeztah
commented
Dec 12, 2019
MemberAuthor
@cpuguy83 rebased 👍 |
tonistiigi
approved these changes
Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #2213
These subcommands were created to allow upgrading a Docker Community engine to Docker Enterprise, but never really took off.
This patch removes the
docker enginesubcommands, as they added quite some complexity / additional code.Signed-off-by: Sebastiaan van Stijn github@gone.nl
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)